CI: stop rebuilding everything in every step! #8678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madelinevibes
added
the
Status::Ready for Review
Collaborator
|
Will the |
Make cdump-enumstr use libccan.a, rather than explicit ccan object: it's the last one. And mark submodcheck phony, as it is. Signed-off-by: Rusty Russell <[email protected]>
This means we don't have to include them in our bundle. Signed-off-by: Rusty Russell <[email protected]>
Here are the speeds and sizes of different compressors: gzip -1: 0m20.914s 789012066 gzip -2: 0m23.846s 775576167 gzip -3: 0m26.088s 765520181 gzip -4: 0m28.264s 748485795 gzip -5: 0m35.916s 736567221 gzip -6: 0m49.906s 730337022 gzip -7: 1m2.391s 728726884 bzip2: 1m32.191s 711695852 gzip -8: 1m51.655s 727303811 gzip -9: 2m51.123s 726946796 Uncompressing time: bzip2: 0m43.353s gzip -5: 0m8.318s The downside is that this is only useful on a *freshly built* tree: it will include everything config.vars and newer. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/ci-no-rebuild
branch
from
2f227b7 to
b431b4f
Compare
…builds. For CI we want to make sure we don't rebuild. CC=false doesn't work because we reply on the output of "$CC -dumpmachine" for the external build directory. So we would use: make CC=devtools/cc-nobuild CARGO=false Signed-off-by: Rusty Russell <[email protected]>
`make check-docs` requires a full build (to check --help information against docs). So move these checks to a `postbuild` CI stage. Signed-off-by: Rusty Russell <[email protected]>
We use the same fragment everywhere for consistency, even though some stages don't actually call make. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/ci-no-rebuild
branch
from
b431b4f to
089b759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our build steps are not working, in the sense we are rebuilding every time.
Changelog-None: build only.